From 75cab8aa88e458ff91ceac72f3dc3f97ba50499d Mon Sep 17 00:00:00 2001 From: Jes Sorensen Date: Mon, 31 Jan 2011 12:23:22 -0200 Subject: [PATCH 28/37] qemu-option: Fix uninitialized value in append_option_parameter RH-Author: Jes Sorensen Message-id: <1296476610-28514-19-git-send-email-Jes.Sorensen@redhat.com> Patchwork-id: 17315 O-Subject: [PATCH 18/26] qemu-option: Fix uninitialized value in append_option_parameter Bugzilla: 637701 RH-Acked-by: Alex Williamson RH-Acked-by: Marcelo Tosatti RH-Acked-by: Kevin Wolf From: Kevin Wolf When dest is NULL, i.e. a new copy of the list is created, we don't get a properly terminated list after the realloc. Initialize it as an empty list. Signed-off-by: Kevin Wolf Signed-off-by: Anthony Liguori (cherry picked from commit bd69fe8448024258d046e2a15d4cf5c498188144) --- qemu-option.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) Signed-off-by: Luiz Capitulino --- qemu-option.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/qemu-option.c b/qemu-option.c index 9512370..9cbb090 100644 --- a/qemu-option.c +++ b/qemu-option.c @@ -378,6 +378,7 @@ QEMUOptionParameter *append_option_parameters(QEMUOptionParameter *dest, num_options += count_option_parameters(list); dest = qemu_realloc(dest, (num_options + 1) * sizeof(QEMUOptionParameter)); + dest[num_dest_options].name = NULL; while (list && list->name) { if (get_option_parameter(dest, list->name) == NULL) { -- 1.7.4.rc1.16.gd2f15e