From ec78292f39857251ed3f511b50568bd62fcd9cea Mon Sep 17 00:00:00 2001 Message-Id: In-Reply-To: <707b9b97153063374d2530e72c49b1499fc21af9.1367947969.git.minovotn@redhat.com> References: <707b9b97153063374d2530e72c49b1499fc21af9.1367947969.git.minovotn@redhat.com> From: Laszlo Ersek Date: Mon, 6 May 2013 19:27:40 +0200 Subject: [PATCH 075/114] qemu-ga: qmp_guest_file_close(): fix fclose() error check RH-Author: Laszlo Ersek Message-id: <1367868499-27603-18-git-send-email-lersek@redhat.com> Patchwork-id: 51116 O-Subject: [RHEL-6.5 qemu-kvm PATCH v2 17/56] qemu-ga: qmp_guest_file_close(): fix fclose() error check Bugzilla: 952873 RH-Acked-by: Jeffrey Cody RH-Acked-by: Gerd Hoffmann RH-Acked-by: Paolo Bonzini From: Luiz Capitulino fclose() returns EOF on error. Signed-off-by: Luiz Capitulino Reviewed-by: Michael Roth Signed-off-by: Michael Roth (cherry picked from commit 3ac4b7c51e3ba181a86983ba2601a595ed8f3b1d) Signed-off-by: Laszlo Ersek --- qga/commands-posix.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) Signed-off-by: Michal Novotny --- qga/commands-posix.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qga/commands-posix.c b/qga/commands-posix.c index ea4dbcb..541a828 100644 --- a/qga/commands-posix.c +++ b/qga/commands-posix.c @@ -171,7 +171,7 @@ void qmp_guest_file_close(int64_t handle, Error **err) } ret = fclose(gfh->fh); - if (ret == -1) { + if (ret == EOF) { error_set(err, QERR_QGA_COMMAND_FAILED, "fclose() failed"); return; } -- 1.7.11.7