From 1e3347e82016c88a414260cc7449832e1c83a781 Mon Sep 17 00:00:00 2001 Message-Id: <1e3347e82016c88a414260cc7449832e1c83a781.1342518105.git.minovotn@redhat.com> In-Reply-To: <27a73856ecc481c66c7afac8171f753887f32e31.1342518105.git.minovotn@redhat.com> References: <27a73856ecc481c66c7afac8171f753887f32e31.1342518105.git.minovotn@redhat.com> From: Luiz Capitulino Date: Tue, 5 Jun 2012 14:58:38 +0200 Subject: [PATCH 29/41] qemu-ga: guest-suspend-disk: don't emit a success response RH-Author: Luiz Capitulino Message-id: <1338908331-15633-24-git-send-email-lcapitulino@redhat.com> Patchwork-id: 39920 O-Subject: [PATCH RHEL6.4 qemu-kvm 23/36] qemu-ga: guest-suspend-disk: don't emit a success response Bugzilla: 827612 RH-Acked-by: Paolo Bonzini RH-Acked-by: Juan Quintela RH-Acked-by: Jeffrey Cody Today, qemu-ga may not be able to emit a success response when guest-suspend-disk completes. This happens because the VM may vanish before qemu-ga is able to emit a response. This semantic is a bit confusing, as it's not clear for clients if they should wait for a response or how they should check for success. This commit solves that problem by changing guest-suspend-disk to never emit a success response and suggests in the documentation what clients could do to check for success. Signed-off-by: Luiz Capitulino Signed-off-by: Michael Roth (cherry picked from commit c6fcc10ab31d22e93eb169c451025ac9636ec84b) Signed-off-by: Luiz Capitulino --- qapi-schema-guest.json | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) Signed-off-by: Michal Novotny --- qapi-schema-guest.json | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/qapi-schema-guest.json b/qapi-schema-guest.json index 1dd3454..88b165c 100644 --- a/qapi-schema-guest.json +++ b/qapi-schema-guest.json @@ -363,17 +363,21 @@ # For the best results it's strongly recommended to have the pm-utils # package installed in the guest. # -# Returns: nothing on success +# This command does NOT return a response on success. There is a high chance +# the command succeeded if the VM exits with a zero exit status or, when +# running with --no-shutdown, by issuing the query-status QMP command to +# to confirm the VM status is "shutdown". However, the VM could also exit +# (or set its status to "shutdown") due to other reasons. +# +# The following errors may be returned: # If suspend to disk is not supported, Unsupported # -# Notes: o This is an asynchronous request. There's no guarantee a response -# will be sent -# o It's strongly recommended to issue the guest-sync command before -# sending commands when the guest resumes +# Notes: It's strongly recommended to issue the guest-sync command before +# sending commands when the guest resumes # # Since: 1.1 ## -{ 'command': 'guest-suspend-disk' } +{ 'command': 'guest-suspend-disk', 'success-response': 'no' } ## # @guest-suspend-ram -- 1.7.10.4